ZonedDateTime.toLocaleString() and last cookbook example #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1153 +/- ##
==========================================
- Coverage 93.55% 90.63% -2.93%
==========================================
Files 19 17 -2
Lines 7961 8797 +836
Branches 1264 1245 -19
==========================================
+ Hits 7448 7973 +525
- Misses 506 813 +307
- Partials 7 11 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
16 tasks
Ms2ger
requested changes
Nov 9, 2020
The ZonedDateTime's time zone wins over the system's default time zone. If you explicitly give a time zone in the formatter options, and you try to format a ZonedDateTime with a time zone which is different from the explicitly given time zone, then toLocaleString() will throw an exception. formatRange() and formatRangeToParts() require ZonedDateTimes with the same time zone. See: #569
Now that ZonedDateTime.toLocaleString() works, we can fix this example. It becomes much simpler using ZonedDateTime. See: #569
In DateTimeFormat.format, we need to call toString() to get the calendar ID only once, instead of several times.
ptomato
force-pushed
the
zoneddatetime-8
branch
from
0240ac2 to
06ea4f4
Compare
justingrant
approved these changes
Nov 10, 2020
|
|
||
| // Show the date in midnight cells | ||
| let formatOptions; | ||
| if (dt.hour === 0) { | ||
| if (columnTime.hour === 0) { |
There was a problem hiding this comment.
I think you probably want to compare columnTime to .startOfDay here, not zero, if you want to handle cases where DST skips an hour starting at midnight.
There was a problem hiding this comment.
That's a good point, it does handle other skipped and repeated times gracefully, so it should here as well.
Ms2ger
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #569