Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporal.Duration.prototype.toString: If-condition should use "and" instead of "or" #3009

Closed
anba opened this issue Oct 15, 2024 · 1 comment · Fixed by #3012
Closed

Temporal.Duration.prototype.toString: If-condition should use "and" instead of "or" #3009

anba opened this issue Oct 15, 2024 · 1 comment · Fixed by #3012
Labels
editorial spec-text Specification text involved

Comments

@anba
Copy link
Contributor

anba commented Oct 15, 2024

Temporal.Duration.prototype.toString, step 10:

  1. If precision.[[Unit]] is nanosecond or precision.[[Increment]] = 1, then

or should instead be and.
@ptomato
Copy link
Collaborator

ptomato commented Oct 15, 2024

Thanks for catching this as well. It's a semantic change that was introduced by mistake in 730e676 (#2943) and so did not have consensus, therefore I'm assuming it does not need consensus to revert it.

@ptomato ptomato added spec-text Specification text involved editorial labels Oct 15, 2024
ptomato added a commit that referenced this issue Oct 15, 2024
@ptomato
Editorial: Fix condition in Temporal.Duration.prototype.toString
7d8efcd 
Inadvertent semantic change from 730e676
that must be reverted.

Closes: #3009
@ptomato ptomato mentioned this issue Oct 15, 2024
Merged
ptomato added a commit that referenced this issue Oct 28, 2024
@ptomato
Editorial: Fix condition in Temporal.Duration.prototype.toString
777ee00 
Inadvertent semantic change from 730e676
that must be reverted.

Closes: #3009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
editorial spec-text Specification text involved
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Editorial: Address feedback from Anba tc39/proposal-temporal
2 participants
@ptomato @anba