Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToTemporalDuration: CreateTemporalDuration is fallible #2992

Closed
anba opened this issue Oct 1, 2024 · 0 comments
Closed

ToTemporalDuration: CreateTemporalDuration is fallible #2992

anba opened this issue Oct 1, 2024 · 0 comments
Assignees
@ptomato
Labels
editorial spec-text Specification text involved

Comments

@anba
Copy link
Contributor

anba commented Oct 1, 2024

ToTemporalDuration, step 15:

  1. Return ! CreateTemporalDuration(result.[[Years]], result.[[Months]], result.[[Weeks]], result.[[Days]], result.[[Hours]], result.[[Minutes]], result.[[Seconds]], result.[[Milliseconds]], result.[[Microseconds]], result.[[Nanoseconds]]).

CreateTemporalDuration is fallible, because result can contain too large values.
@ptomato ptomato self-assigned this Oct 1, 2024
@ptomato ptomato added spec-text Specification text involved editorial labels Oct 1, 2024
ptomato added a commit that referenced this issue Oct 2, 2024
@ptomato
Editorial: Object path of ToTemporalDuration is fallible
9098fe6 
This mistakenly became an assertion in PR #2943. By inspection it is easy
to come up with a case where CreateTemporalDuration is fallible, and this
is well covered in test262.

Closes: #2992
@Ms2ger Ms2ger closed this as completed in 14a3fc8 Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ptomato ptomato

Labels
editorial spec-text Specification text involved
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ptomato @anba