Skip to content
This repository has been archived by the owner on Jan 25, 2022. It is now read-only.

Checklist: Stage 4 entrance criteria #43

Open
10 of 12 tasks
leobalter opened this issue Mar 28, 2019 · 16 comments
Open
10 of 12 tasks

Checklist: Stage 4 entrance criteria #43

leobalter opened this issue Mar 28, 2019 · 16 comments

Comments

@leobalter
Copy link
Member

leobalter commented Mar 28, 2019

@chicoxyzzy
Copy link
Member

It's implemented in V8 now

@samuelgoto
Copy link
Collaborator

samuelgoto commented Apr 16, 2019 via email

@leobalter
Copy link
Member Author

needs shipping (M75) to flag the box :)

@chicoxyzzy
Copy link
Member

Implemented in Firefox Nightly 68 which will be released on July 9

Chrome 75 will be released on June 4

@boingoing
Copy link

This is implemented in ChakraCore now (chakra-core/ChakraCore#6143).

I'm not sure what the schedule is for cutting a new release branch with this enabled, though.

@chicoxyzzy
Copy link
Member

@chicoxyzzy
Copy link
Member

Shipped in Safari 13 update which is bundled with macOS Catalina beta

@ljharb
Copy link
Member

ljharb commented Jun 19, 2019

Note that additional stage 4 entrance criteria include having an editor-approved PR to the main spec.

@chicoxyzzy
Copy link
Member

chicoxyzzy commented Oct 16, 2019

@leobalter I think you can add check marks for JSC, ChakraCore and TypeScript. Firefox will have numerics separators support enabled by default in version 70, which is planned for October 22.

@leobalter
Copy link
Member Author

It's on for ChakraCore but still w/ a flag, if I'm correct.

Thanks for the update. Now it's time for the champions to move this forward. cc @rwaldron @samuelgoto

@chicoxyzzy
Copy link
Member

chicoxyzzy commented Oct 16, 2019

It looks like default value for numeric separator flag in ChakraCore is true. Though I could miss something.

@rhuanjl
Copy link

rhuanjl commented Dec 6, 2019

@chicoxyzzy if you build chakracore for yourself from the master branch this feature is enabled. However if you download a released version of chakracore or use Edge this feature is not there. The last release of chakracore to incorporate any new feature work was in June 2018 (version 1.10) all releases since then have been security fixes only. A lot of feature work has been done since then but it's all only in the master branch and hence only usable by people who compile it themselves.

@chicoxyzzy
Copy link
Member

@rhuanjl thank you for the clarification

@avp
Copy link

avp commented Jul 8, 2020

Added to Hermes in facebook/hermes@f0006aa

@leobalter
Copy link
Member Author

Thanks @avp! I updated the list to reflect this.

@tchetwin
Copy link

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants