Editorial: Use internal spec value for param #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using an ECMAScript string value to represent internal state may cause readers to incorrectly assume that the state is directly observable from ECMAScript code. Replace with a internal specification value in accordance with the latest practice in ECMA262 [1]. Modify the values so that they will be distinctive in the context of the specification in order to facilitate tool-assisted search (e.g. via the `grep` command-line utility or via "Ctrl+F" in a web browser). [1] tc39/ecma262#2566
Codecov Report
@@ Coverage Diff @@
## master #52 +/- ##
=======================================
Coverage 99.37% 99.37%
=======================================
Files 1 1
Lines 160 160
Branches 50 50
=======================================
Hits 159 159
Misses 1 1 Continue to review full report at Codecov.
|
ljharb
approved these changes
Nov 12, 2021
Jack-Works
approved these changes
Nov 13, 2021
Jack-Works
reviewed
Nov 13, 2021
| @@ -33,9 +33,9 @@ contributors: "Jack Works" | |||
| <h1><dfn>CreateNumericRangeIterator</dfn>(_start_, _end_, _option_, _type_)</h1> | |||
| <emu-alg> | |||
| 1. If Type(_start_) is not _type_, throw a *TypeError* exception. | |||
There was a problem hiding this comment.
Actually this step uses _type_ as a runtime ECMAScript value for comparison of typeof _start_ === _type_. Let me fix this.
There was a problem hiding this comment.
The Type abstract operation is not the same thing as the ECMAScript typeof operator. In particular, it returns the name of a type, not an ES language string (or a spec enum).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using an ECMAScript string value to represent internal state may cause
readers to incorrectly assume that the state is directly observable from
ECMAScript code. Replace with a internal specification value in
accordance with the latest practice in ECMA262 [1].
Modify the values so that they will be distinctive in the context of the
specification in order to facilitate tool-assisted search (e.g. via the
grepcommand-line utility or via "Ctrl+F" in a web browser).[1] tc39/ecma262#2566