This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
Formatter to include support for all units #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rxaviers
commented
Mar 20, 2017
README.md
Outdated
| -1, | ||
| "day" // "second", "minute", "hour", "day", "week", "month", "quarter", or "year". | ||
| ); | ||
| // > "1 day ago" |
There was a problem hiding this comment.
Note this is not using the text type.
rxaviers
commented
Mar 20, 2017
README.md
Outdated
| // > "in 100 days" | ||
|
|
||
| rtf.format(0, "day"); | ||
| // > "0 days ago" / "in 0 days" ?? |
There was a problem hiding this comment.
Note that we have this situation using this approach. Need to evaluate what ICU does...
There was a problem hiding this comment.
There's "0" and "-0" in JS. We may want to use it.
rxaviers
commented
Mar 20, 2017
README.md
Outdated
| @@ -24,7 +24,7 @@ TBD | |||
|
|
|||
| ### Informative | |||
|
|
|||
| This proposal is based on Unicode Relative Date Time Format method. | |||
| This proposal is based on Unicode Relative Date Time Format method and on the ICU . | |||
There was a problem hiding this comment.
Note to self: Update this information appropriately.
|
@caridy and @zbraniecki I'm creating this PR for early feedback, therefore I started by updating the README examples so that we exercise this approach in a clear manner. |
rxaviers
force-pushed
the
all-units-formatter
branch
3 times, most recently
from
a37b450 to
2ebd515
Compare
rxaviers
force-pushed
the
all-units-formatter
branch
from
2ebd515 to
145b76e
Compare
caridy
reviewed
Mar 21, 2017
| 1. If _exists_ is *true*, then | ||
| 1. Let _result_ be Get(_patterns_, ToString(_v_)). | ||
| 1. Return _result_. | ||
| 1. Let _v_ be _value_.[[<_unit_>]]. |
There was a problem hiding this comment.
going forward we want to avoid accessing internal slots for computed values, e.g.: [[<x>]], I'm ok with this for now.
caridy
approved these changes
Mar 21, 2017
|
I'm all for it. |
zbraniecki
approved these changes
Mar 22, 2017
|
🎉 |
caridy
approved these changes
Mar 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR that will eventually:
best fit#12nowwhen calling format() #4TODO