-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make firstDayOfWeek return string and fix spec bug #79
Conversation
Sorry. I just realize this PR is not good enough. Need more work. I need to rework on this. Intl.Locale.prototype.firstDayOfWeek need to return string, but not just that 7 string values. |
|
@sffc @anba @ben-allen ping |
Hey @FrankYFTang - While implementing this, I came across a small issue. I think
Where |
@FrankYFTang @ptomato Maybe we should update test262 for this? |
It's not clear to me what changed just from looking at the PR, but yes please do update test262 if it's needed. |
fork that issue into #82 |
Spec Changes merged tc39/proposal-intl-locale-info#79
Spec Changes merged tc39/proposal-intl-locale-info#79
Spec Changes merged tc39/proposal-intl-locale-info#79
Update the implementation to sync with https://tc39.es/proposal-intl-locale-info/ Change to reflect tc39/proposal-intl-locale-info#79 Bug: 42204095 Change-Id: Ie0aeb104499e3e7e600e1ab2b0c54ac112ff7930 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5690278 Reviewed-by: Frank Tang <ftang@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/main@{#94950}
This revert our change after TC39 Sept meeting so
I. Intl.Locale.prototype.firstDayOfWeek returns any strings which fit type = alphanum{3,8} (sep alphanum{3,8})*. as defined in UTS35
2. {firstDayOfWeek} for new Intl.Locale() accepts: strings fit Default: undefined