Skip to content
This repository has been archived by the owner on Jul 31, 2023. It is now read-only.

Normative: add "canonical" to AvailableCanonical(Calendars|Collations|NumberingSystems) #43

Merged
merged 4 commits into from
Nov 3, 2022

Conversation

FrankYFTang
Copy link
Collaborator

@sffc
Copy link
Collaborator

sffc commented Apr 21, 2022

CC @ptomato since you recently commented on the linked issue

@ptomato
Copy link
Contributor

ptomato commented Apr 21, 2022

Thanks for tagging me in!

I would actually prefer that we go the other way with this. That is, the Available___ operations return both canonical and non-canonical names, and we also define Canonicalize___Name operations, so that in supportedValuesOf we can filter out the non-canonical ones.

The reason for this is because I'd like to bring AvailableCalendars and AvailableTimeZones into 262 along with Temporal, and implement IsValidTimeZoneName in terms of those. The current definition of AvailableTimeZones uses IsValidTimeZoneName and CanonicalizeTimeZoneName, so that wouldn't be possible as written.

I can write a PR for this proposal demonstrating what I mean, if that would be helpful.

@FrankYFTang
Copy link
Collaborator Author

I can write a PR for this proposal demonstrating what I mean, if that would be helpful.

Please show us your counterplan and we can discuss that. Thanks!

@FrankYFTang
Copy link
Collaborator Author

@ptomato ping- We are waiting for your " PR for this proposal demonstrating what I mean."

@ptomato
Copy link
Contributor

ptomato commented Jul 16, 2022

I have opened #49 as a counterproposal, please let me know what you think.

@FrankYFTang
Copy link
Collaborator Author

I thiink #49 is beyond the scope of this proposal. The goal of this proposal is to provide functionality for the userland code to ues, not to make the future spec writer reuse AOs beyond what this spec intend to provide- especially not to change the rest of the ECMA402 to use those AOs. Those operations needs a separate discussion beyond what this proposal intend to solve.

@FrankYFTang FrankYFTang changed the title Normative: add "canonical" to Available(Calendars|Collations|NumberingSystems) Normative: add "canonical" to AvailableCanonical(Calendars|Collations|NumberingSystems) Sep 29, 2022
@FrankYFTang FrankYFTang requested review from sffc and anba September 29, 2022 20:27
@FrankYFTang
Copy link
Collaborator Author

@anba - do you think this PR would address the issue you mentioned in #37 sorry for the delay. @sffc @ryzokuken @gibson042 please review

@anba
Copy link
Collaborator

anba commented Sep 30, 2022

@anba - do you think this PR would address the issue you mentioned in #37 sorry for the delay.

Yes, I think that should be okay. We can later integrate the algorithms from #49 to more formally specify what "canonical" means.

@sffc
Copy link
Collaborator

sffc commented Nov 2, 2022

As a reminder, please make sure there is a follow-up issue filed in the ecma402 repo to continue this discussion after this proposal lands as stage 4.

@ptomato
Copy link
Contributor

ptomato commented Nov 2, 2022

As a reminder, please make sure there is a follow-up issue filed in the ecma402 repo to continue this discussion after this proposal lands as stage 4.

tc39/ecma402#726

@FrankYFTang FrankYFTang merged commit 075a6dc into master Nov 3, 2022
@FrankYFTang FrankYFTang deleted the FrankYFTang-patch-2 branch November 3, 2022 04:11
FrankYFTang added a commit to FrankYFTang/ecma402 that referenced this pull request Nov 29, 2022
ryzokuken pushed a commit to tc39/ecma402 that referenced this pull request Apr 3, 2023
* Normative: Stage4 PR for proposal-intl-enumeration

Plan to suggest moving to Stage 4 in Nov 2022
https://github.com/tc39/proposal-intl-enumeration

It is already implemented in Chrome m99, Safari 15.4 and Firefox 93.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/supportedValuesOf#browser_compatibility

* sync w/ intl-enumeration pull/43

tc39/proposal-intl-enumeration#43

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

---------

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
ben-allen pushed a commit to ben-allen/ecma402 that referenced this pull request Apr 10, 2023
* Normative: Stage4 PR for proposal-intl-enumeration

Plan to suggest moving to Stage 4 in Nov 2022
https://github.com/tc39/proposal-intl-enumeration

It is already implemented in Chrome m99, Safari 15.4 and Firefox 93.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/supportedValuesOf#browser_compatibility

* sync w/ intl-enumeration pull/43

tc39/proposal-intl-enumeration#43

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

---------

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
ben-allen pushed a commit to ben-allen/ecma402 that referenced this pull request Apr 11, 2023
* Normative: Stage4 PR for proposal-intl-enumeration

Plan to suggest moving to Stage 4 in Nov 2022
https://github.com/tc39/proposal-intl-enumeration

It is already implemented in Chrome m99, Safari 15.4 and Firefox 93.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/supportedValuesOf#browser_compatibility

* sync w/ intl-enumeration pull/43

tc39/proposal-intl-enumeration#43

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

* Update spec/locales-currencies-tz.html

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>

---------

Co-authored-by: Richard Gibson <richard.gibson@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants