This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
Set field widths for date/timeStyle #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… widths Change [[DateFormat]] and [[TimeFormat]] to use a record instead of a simple pattern. That way field widths (e.g. display "hour" as "2-digit") can be stored.
The returned record has the same structure as the one returned from `BasicFormatMatcher` and `BestFitFormatMatcher`.
Unify the steps to initialise the internal slots of a DateTimeFormat object from the format record.
This now happens as part of the normal hour-cycle computation steps.
This change from ECMA-402 is no longer needed.
… when date/timeStyle is used The DateTimeFormat's internal slots for date-time compenents are now correctly filled, so they need to explicitly filtered out in `resolvedOptions()`.
This change from ECMA-402 isn't needed anymore, too.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #45
#48 (comment) contains small descriptions for these commits.