Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish rename to import assertions #88

Merged
merged 4 commits into from
Jul 23, 2020

Conversation

dandclark
Copy link
Collaborator

Finish the rename to 'import assertions' started in 3d71669 by updating all remaining references from 'condition' to 'assertion' in the README and the spec text.

@dandclark dandclark requested review from littledan and xtuc July 22, 2020 23:13
@dandclark
Copy link
Collaborator Author

We'll want to change the actual repository name prior to landing this, or at the same time, or all the links will be broken.
Alternatively I can split out the URL changes and land those separately.

Copy link
Member

@littledan littledan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The renamings will continue until morale improves!

Landing this together SGTM. It seems like you should have permissions to do the repo move, so as long as you do that soon, it should be good. Let me know if you need anything from me for that.

@dandclark dandclark merged commit dc2f3fb into master Jul 23, 2020
@dandclark dandclark deleted the dandclark/finish-rename-to-assertions branch July 23, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants