This repository has been archived by the owner on Jan 26, 2022. It is now read-only.
spec: rename CreateNonEnumerableDataProperty to CreateNonEnumerableDataPropertyOrThrow #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
force-pushed
the
fix-create-non-enumerable-data-property
branch
from
4eb4ba9
to
79f07b7
Compare
ljharb
suggested changes
Mar 3, 2021
spec.emu
Outdated
| 1. <ins>Let _newDesc_ be the PropertyDescriptor { [[Value]]: _V_, [[Writable]]: *true*, [[Enumerable]]: *false*, [[Configurable]]: *true* }.</ins> | ||
| 1. <ins>Return ? DefinePropertyOrThrow(_O_, _P_, _newDesc_).</ins> | ||
| 1. <ins>Return ? ? _O_.[[DefineOwnProperty]](_P_, _newDesc_).</ins> |
There was a problem hiding this comment.
Why is this an improvement? The behavior of returning false on failure has caused a number of spec bugs, which is why most of them have been changed to call DefinePropertyOrThrow with ?.
There was a problem hiding this comment.
Based on the linked comment, the AO should have an “OrThrow” in the name, rather than not throwing at all.
legendecas
force-pushed
the
fix-create-non-enumerable-data-property
branch
from
42855a1
to
71e533d
Compare
legendecas
changed the title
|
@ljharb thanks for the context. I've updated the PR with renaming the AO to indicate they are throwing on failure. |
ljharb
approved these changes
Mar 4, 2021
spec.emu
Outdated
| <p><ins>The abstract operation CreateNonEnumerableDataProperty takes arguments _O_ (an Object), _P_ (a property key), and _V_ (an ECMAScript language value). It performs the following steps when called:</ins></p> | ||
| <emu-clause id="sec-createnonenumerabledatapropertyorthrow"> | ||
| <h1><ins>CreateNonEnumerableDataPropertyOrThrow ( _O_, _P_, _V_ )</ins></h1> | ||
| <p><ins>The abstract operation CreateNonEnumerableDataPropertyOrThrow takes arguments _O_ (an Object), _P_ (a property key), and _V_ (an ECMAScript language value). It is used to create a new non-enumerable own property of an object. It throws a *TypeError* exception if the requested property update cannot be performed. It performs the following steps when called:</ins></p> |
There was a problem hiding this comment.
Suggested change
| <p><ins>The abstract operation CreateNonEnumerableDataPropertyOrThrow takes arguments _O_ (an Object), _P_ (a property key), and _V_ (an ECMAScript language value). It is used to create a new non-enumerable own property of an object. It throws a *TypeError* exception if the requested property update cannot be performed. It performs the following steps when called:</ins></p> | |
| <p><ins>The abstract operation CreateNonEnumerableDataPropertyOrThrow takes arguments _O_ (an Object), _P_ (a Property Key), and _V_ (an ECMAScript language value). It is used to create a new non-enumerable own property of an object. It throws a *TypeError* exception if the requested property update cannot be performed. It performs the following steps when called:</ins></p> |
spec.emu
Outdated
Comment on lines
50
to
51
| 1. <ins>Assert: Type(_O_) is Object.</ins> | ||
| 1. <ins>Assert: IsPropertyKey(_P_) is true.</ins> | ||
| 1. <ins>Assert: IsPropertyKey(_P_) is *true*.</ins> |
There was a problem hiding this comment.
these two can be removed, since they're now redundant
legendecas
force-pushed
the
fix-create-non-enumerable-data-property
branch
from
15d303e
to
6aaffb9
Compare
…taPropertyOrThrow
legendecas
force-pushed
the
fix-create-non-enumerable-data-property
branch
from
6aaffb9
to
9192e7a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update abstract operation CreateNonEnumerableDataProperty with name CreateNonEnumerableDataPropertyOrThrow to indicate the AO is throwing on unable to perform the creation.
Refs: #2 (comment)