-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure to propagate a promise job's snapshot when handling abrupt completions #41
Make sure to propagate a promise job's snapshot when handling abrupt completions #41
Conversation
6ae967d
to
ac0cda4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this change, I don't think we need HostCallJobCallback
at all. And if we land on something like #16, we'd be able to remove HostMakeJobCallback
and instead store directly on the PromiseCapability
.
True, I hadn't realized these promise jobs were the only users of I don't think it's yet fully clear which option to go for in #16, so I think getting rid of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to update CleanupFinalizationRegistry
, otherwise LGTM
2909076
to
68bab19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased this and resolved merge conflicts.
Closes #35.