Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ add additional example to test assertions #298

Merged
merged 2 commits into from
Nov 1, 2023
Merged

✅ add additional example to test assertions #298

merged 2 commits into from
Nov 1, 2023

Conversation

ctcpip
Copy link
Member

@ctcpip ctcpip commented Oct 31, 2023 •
edited
Loading

don't merge this yet...

@ctcpip ctcpip mentioned this pull request Oct 31, 2023
Merged
@ctcpip
Copy link
Member Author

ctcpip commented Oct 31, 2023

@acutmore alright, I think we're good to go. have a look at the new regex, before/after test examples, and if you like, the resulting changes to existing notes. @ljharb FYI I'd prefer to not squash these commits.

@ctcpip ctcpip requested a review from ljharb November 1, 2023 15:36
@ctcpip ctcpip mentioned this pull request Nov 1, 2023
Closed
@ctcpip ctcpip merged commit 4e98ee2 into main Nov 1, 2023
2 checks passed
@ctcpip ctcpip deleted the add-test-case branch November 1, 2023 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acutmore acutmore acutmore approved these changes

@ljharb ljharb Awaiting requested review from ljharb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctcpip @acutmore