Editorial: Add CSS to adjust list bullets to match ECMA #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takikawa
changed the title
Numbered bullets in algorithhms in ECMA standards repeat a pattern of decimal, lower alpha, lower roman. Bikeshed uses just decimal by default. This commit changes the pattern to match ECMA. Note that this also affects non-algorithm bullets as well, as we don't distinguish those in the source.
takikawa
force-pushed
the
adjust-list-bullets
branch
from
c11c29d to
545783a
Compare
Yeah, it seems reasonable to use an unordered lists for things that don't have a meaningful order of any type. |
nicolo-ribaudo
approved these changes
Nov 21, 2024
github-actions bot
added a commit
that referenced
this pull request
Nov 21, 2024
SHA: 1bd4b5c Reason: push, by nicolo-ribaudo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Dec 6, 2024
nicolo-ribaudo
pushed a commit
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now the draft PDF spec (in ECMA format) and the web spec don't align on the numbered bullet styles in algorithms. This PR changes the web version to match using CSS.
This also changes numbered bullets that aren't in algorithms, such as those in "5.1.2. Names for generated JavaScript code" (which is not in the 2024 branch) because we don't have a CSS class to distinguish them. I think in that particular case, we could just use unordered lists instead if we don't like the alternating bullets.