Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future of X- Prefixes #25

Closed
mitsuhiko opened this issue Apr 6, 2023 · 7 comments
Closed

Future of X- Prefixes #25

mitsuhiko opened this issue Apr 6, 2023 · 7 comments

Comments

@mitsuhiko
Copy link
Contributor

I have no strong opinions here but I came across this again. HTTP no longer recommends x- prefixes, the future of x_ prefixes in this specification should maybe be reconsidered.

At least I would argue that we should not recommend vendor prefixes. If we think for instance that ignoreList is a useful thing, it's odd that all tools are supposed to refer to this as x_google_ignoreList.

@littledan
Copy link
Member

We use some vendor prefixes at Bloomberg. I'm not really sure if vendor prefixes are a bad thing here.

@bmeurer
Copy link

bmeurer commented Apr 26, 2023

My 2 cents here is that vendor prefixes are a quite useful way to experiment with new ideas. Let's take the case of x_google_ignoreList: The vendor prefix allowed us to experiment with this and get this in front of real users to understand whether we are really solving the right problem here, and we can now bring that understanding to the standards body to agree on how to properly standardize it (which could be as simple as removing the x_google_ from the beginning and having tools support both x_google_ignoreList and ignoreList for a few releases).

@mitsuhiko
Copy link
Contributor Author

I guess I'm devil's advocate here but I think the fundamental findings of RFC 6648 which recommends against the X- prefix for new experimental HTTP headers apply to source maps too (See appendix B).

@jkup
Copy link
Collaborator

jkup commented Aug 9, 2023

I think a lot of people like the freedom for vendors to experiment with x-prefixes but, as Armin says, there have been a ton of cases where people have "experimented" with an x-prefix and then the thing gets standardized and then we have to go through and get rid of the x-prefix. Like is the case now with the x_google_ignoreList which we'd like to move and rename (since Firefox uses it too).

Maybe the best way forward is to work together on moving the x_google_ignoreList into a more official name, see how we like that process and then circle back on our recommendations on x-prefixes in general?

@jkup
Copy link
Collaborator

jkup commented Sep 22, 2023

Since Google and Mozilla seem happy with this, can we add an official ignoreList to the spec? @mitsuhiko brought up a good point about what to do if both show up. Let's talk about this further.

For x-prefixes in general, this seems like it merits more discussion.

@EricSL
Copy link
Contributor

EricSL commented Oct 5, 2023

For the x_google_ignoreList change, I made a pull request: tc39/source-map-spec#19

@littledan
Copy link
Member

Will be fixed by tc39/source-map-spec#24

nicolo-ribaudo pushed a commit to nicolo-ribaudo/source-map that referenced this issue Mar 13, 2024
Add statement about possibility of source map rejecting in case of an invalid version field
@jkup jkup closed this as completed Jun 24, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Source map Spec Standardization Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants