Normative: Canonicalize overriding uvalues in MakeLocaleRecord #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryzokuken
added
normative
has consensus (TG1)
|
Thanks for filing this, @trflynn89! We'll briefly discuss this tonight at the TG2 meeting before hitting merge. |
ryzokuken
approved these changes
Apr 25, 2024
gibson042
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-applies PR #846, which was reverted in commit 3c6d295 due to having been merged before approval.
It received TG1 approval back in February, and according to Feb's meeting notes, the change was meant to have been re-applied. But it seems that was forgotten, and since the original issue (#707) was closed to the first merge, this patch was sort of in limbo.