Editorial: update time zone identifier text #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit includes a few minor updates to spec text about time zone identifiers that I noticed while preparing the Time Zone Canonicalization proposal: * Fixes an inconsistency between text in #sec-time-zone-names (which requires IANA Time Zone Database) and text in two AOs that implies that such support is optional. * Renames `_timeZone_` variable to `_timeZoneIdentifier_` when it's guaranteed to be a string. * Replaces "name" with the more precise "identifier" in a few places.
gibson042
requested changes
Mar 29, 2023
|
oops, just committed to the wrong branch... gimme a few mins to fix. |
|
OK, fixed now. All comments addressed. Should be ready to merge assuming no other issue found. |
gibson042
approved these changes
Mar 29, 2023
ben-allen
pushed a commit
to ben-allen/ecma402
that referenced
this pull request
Apr 10, 2023
* Fix an inconsistency between text in #sec-time-zone-names (which requires IANA Time Zone Database) and text in two AOs that implies that such support is optional. * Rename `_timeZone_` variable to `_timeZoneIdentifier_` when it's guaranteed to be a string. * Replace "name" with the more precise "identifier" in a few places.
ben-allen
pushed a commit
to ben-allen/ecma402
that referenced
this pull request
Apr 11, 2023
* Fix an inconsistency between text in #sec-time-zone-names (which requires IANA Time Zone Database) and text in two AOs that implies that such support is optional. * Rename `_timeZone_` variable to `_timeZoneIdentifier_` when it's guaranteed to be a string. * Replace "name" with the more precise "identifier" in a few places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a few minor updates to spec text about time zone identifiers that I noticed while preparing the Time Zone Canonicalization proposal:
_timeZone_variable to_timeZoneIdentifier_when it's guaranteed to be a string.