Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to group abstract operations per section for NumberFormat and DateTimeFormat #67

Merged
merged 2 commits into from
Jan 28, 2016

Conversation

caridy
Copy link
Contributor

@caridy caridy commented Jan 25, 2016

Disclaimer: This PR does not modify any algo, we just reshuffle them for organizational purposes.

Reasoning

  • "Number Format Functions" holds several abstract operations, and it was a sub-section under "Properties of the Intl.NumberFormat Prototype Object", which is confusing, specially once we add more properties to those objects that could call the same abstract operations. The same applies to "DateTime Format Functions".
  • InitializeNumberFormat() and InitializeDateTimeFormat() abstract operations were under the corresponding constructor section.

Notes

  • moving all abstract operations of NumberFormat Objects into an abstract sub-section
  • moving all abstract operations of DateTimeFormat Objects into an abstract sub-section.

Render Version:

* moving all abstract operations of NumberFormat Objects into the abstract sub-section
* moving all abstract operations of DateTimeFormat Objects into the abstract sub-section.
@zbraniecki
Copy link
Member

+1.

Cool! Let's land it before we move forward with revision 3 changes.

@rwaldron
Copy link
Contributor

@caridy this LGTM, thanks for putting in the time and effort to make these changes

caridy added a commit that referenced this pull request Jan 28, 2016
PR #67: Refactor to group abstract operations per section for `NumberFormat` and `DateTimeFormat`
@caridy caridy merged commit 9887d9b into master Jan 28, 2016
@caridy caridy deleted the extracting-abstracts branch January 28, 2016 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants