Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Remove unnecessary specification of supportedLocalesOf length properties #618

Conversation

gibson042
Copy link
Contributor

@gibson042 gibson042 commented Oct 25, 2021

Some but not all supportedLocalesOf definitions explicitly specify length, but none of them should need to. However, we might consider updating https://tc39.es/ecma402/#conventions to explicitly adopt https://tc39.es/ecma262/#sec-ecmascript-standard-built-in-objects

Every built-in function object, including constructors, has a "length" property whose value is a non-negative integral Number. Unless otherwise specified, this value is equal to the number of required parameters shown in the subclause heading for the function description. Optional parameters and rest parameters are not included in the parameter count.

Copy link
Member

@ryzokuken ryzokuken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. What about the addition to conventions that you mention? Will you add another commit or should we go for a second PR?

@anba
Copy link
Contributor

anba commented Oct 25, 2021

However, we might consider updating https://tc39.es/ecma402/#conventions to explicitly adopt https://tc39.es/ecma262/#sec-ecmascript-standard-built-in-objects

That's already part of https://tc39.es/ecma402/#requirements.

@gibson042
Copy link
Contributor Author

Great!

@ryzokuken
Copy link
Member

Looks like everything is in order, merging!

Thanks @gibson042 @anba and @ljharb

@ryzokuken ryzokuken merged commit ffa7b27 into tc39:master Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants