Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial- Unify the option value calendar/collation/numberingSystem checking while referring to UTS35 #565

Closed
FrankYFTang opened this issue Apr 14, 2021 · 2 comments · Fixed by #566
Assignees
Labels
c: spec Component: spec editorial issues editorial Involves an editorial fix s: in progress Status: the issue has an active proposal
Milestone

Comments

@FrankYFTang
Copy link
Contributor

This issue is discovered by @ryzokuken while he is reviewing https://github.com/tc39/intl-displaynames-v2 but I think the issue is in the current ECMA402 text itself

https://tc39.es/ecma402/#sec-initializedatetimeformat
7.a. If calendar does not match the Unicode Locale Identifier type nonterminal, throw a RangeError exception.
10. a. If numberingSystem does not match the Unicode Locale Identifier type nonterminal, throw a RangeError exception.

https://tc39.es/ecma402/#sec-initializenumberformat
7.a. If numberingSystem does not match the Unicode Locale Identifier type nonterminal, throw a RangeError exception.

https://tc39.es/ecma402/#sec-initializecollator
11.a. If collation does not match the Unicode Locale Identifier type nonterminal, throw a RangeError exception.

https://tc39.es/ecma402/#sec-InitializeRelativeTimeFormat
7.a. If numberingSystem does not match the type sequence (from UTS 35 Unicode Locale Identifier, section 3.2), throw a RangeError exception.

https://tc39.es/ecma402/#sec-Intl.Locale
14.a. If calendar does not match the type sequence (from UTS 35 Unicode Locale Identifier, section 3.2), throw a RangeError exception.
17.a. If collation does not match the type sequence (from UTS 35 Unicode Locale Identifier, section 3.2), throw a RangeError exception.
27.a. If numberingSystem does not match the type sequence (from UTS 35 Unicode Locale Identifier, section 3.2), throw a RangeError exception.

@ryzokuken
Copy link
Member

Perfect, thanks Frank.

@FrankYFTang FrankYFTang changed the title Editorial- Unify the option value checking Editorial- Unify the option value calendar/collation/numberingSystem checking while referring to UTS35 Apr 14, 2021
FrankYFTang added a commit to FrankYFTang/ecma402 that referenced this issue Apr 15, 2021
Unify the option value calendar/collation/numberingSystem checking while referring to UTS35

Close tc39#565
@sffc sffc added c: spec Component: spec editorial issues editorial Involves an editorial fix s: in progress Status: the issue has an active proposal labels Apr 18, 2021
@sffc sffc added this to the ES 2022 milestone Apr 18, 2021
@sffc
Copy link
Contributor

sffc commented Apr 18, 2021

Related: #395. I think we should consider making a table of calendars like we have for units, date fields, numbering systems, and other things.

ryzokuken pushed a commit that referenced this issue Apr 19, 2021
Unify the option value calendar/collation/numberingSystem checking while referring to UTS35

Close #565
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: spec Component: spec editorial issues editorial Involves an editorial fix s: in progress Status: the issue has an active proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants