Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta: Upgrade ESMeta to v0.5.1 #3508

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Meta: Upgrade ESMeta to v0.5.1 #3508

merged 1 commit into from
Dec 18, 2024

Conversation

jhnaldo
Copy link
Contributor

@jhnaldo jhnaldo commented Dec 18, 2024

We updated the version of ESMeta to v0.5.1.

Using this minor update of the type system, we can remove the following two false alarms:

[ParamTypeMismatch] Call[18183] argument assignment to first parameter _O_ when Call[18183] function call from InstallErrorCause (step 1.a, 3:33-58) to Get
- expected: Record[Object]
- actual  : ESValue

[ReturnTypeMismatch] Block[5523] return statement in GetGlobalObject (step 2, 3:12-51)
- expected: Record[Object]
- actual  : Record[Object] | Undefined

We can also pass the type checking of #3445.

@ljharb ljharb added the meta label Dec 18, 2024
@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Dec 18, 2024
@bakkot bakkot added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Dec 18, 2024
@ljharb ljharb removed the editor call to be discussed in the next editor call label Dec 18, 2024
@ljharb ljharb merged commit effe5f6 into tc39:main Dec 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants