Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Adds change-array-by-copy #2997

Merged
merged 1 commit into from
Mar 12, 2023
Merged

Normative: Adds change-array-by-copy #2997

merged 1 commit into from
Mar 12, 2023

Conversation

acutmore
Copy link
Contributor

@ljharb ljharb added normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. has test262 tests proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. labels Jan 19, 2023
@ljharb ljharb requested review from syg, michaelficarra, bakkot and a team January 19, 2023 19:36
@jmdyck
Copy link
Collaborator

jmdyck commented Jan 19, 2023

Rather than leaving 'suggested change' comments here, I've submitted a PR against this PR's branch: acutmore#2

ljharb
ljharb reviewed Jan 20, 2023
View reviewed changes
spec.html Outdated Show resolved Hide resolved
spec.html Show resolved Hide resolved
ljharb
ljharb reviewed Jan 20, 2023
View reviewed changes
spec.html Outdated Show resolved Hide resolved
ljharb
ljharb reviewed Jan 23, 2023
View reviewed changes
spec.html Outdated Show resolved Hide resolved
syg
syg approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@syg syg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

spec.html Show resolved Hide resolved
spec.html Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
spec.html Outdated Show resolved Hide resolved
@jridgewell jridgewell mentioned this pull request Jan 30, 2023
Open
@sosukesuzuki sosukesuzuki mentioned this pull request Jan 31, 2023
Merged
1 task
@acutmore acutmore force-pushed the change-array-by-copy branch from 9fa4edd to b59c42a Compare February 6, 2023 10:33
@acutmore
Copy link
Contributor Author

acutmore commented Feb 6, 2023

This proposal is now Stage 4: tc39/proposals@ad4df84
Commits squashed and rebased.

@acutmore acutmore marked this pull request as ready for review February 6, 2023 10:34
@acutmore acutmore changed the title [Stage 4 Draft] Normative: Adds change-array-by-copy [Stage 4] Normative: Adds change-array-by-copy Feb 6, 2023
@ljharb ljharb added has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. and removed pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Feb 6, 2023
bakkot
bakkot approved these changes Feb 24, 2023
View reviewed changes
Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than typo.

spec.html Show resolved Hide resolved
@ljharb ljharb force-pushed the change-array-by-copy branch from 5a1df73 to 269c803 Compare February 26, 2023 04:45
michaelficarra
michaelficarra approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@michaelficarra michaelficarra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. There are some opportunities I noticed to use our new interval notation, but I'm not sure what our editorial stance is on that at the moment, so this is fine as-is.

@michaelficarra michaelficarra added the editor call to be discussed in the next editor call label Mar 2, 2023
jmdyck
jmdyck reviewed Mar 2, 2023
View reviewed changes
spec.html Outdated Show resolved Hide resolved
@syg syg added the ready to merge Editors believe this PR needs no further reviews, and is ready to land. label Mar 8, 2023
jmdyck
jmdyck reviewed Mar 10, 2023
View reviewed changes
spec.html Show resolved Hide resolved
spec.html Show resolved Hide resolved
@acutmore @nicolo-ribaudo
@jmdyck @syg @ljharb @linusg
Normative: Adds change-array-by-copy (tc39#2997)
4a32716 
Co-authored-by: Ashley Claymore <aclaymore@bloomberg.net>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Robin Ricard <rricard2@bloomberg.net>
Co-authored-by: Michael Dyck <jmdyck@ibiblio.org>
Co-authored-by: Shu-yu Guo <syg@chromium.org>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Linus Groh <mail@linusgroh.de>
@ljharb ljharb force-pushed the change-array-by-copy branch from 82a40c9 to 4a32716 Compare March 11, 2023 22:17
@ljharb ljharb changed the title [Stage 4] Normative: Adds change-array-by-copy Normative: Adds change-array-by-copy Mar 12, 2023
@ljharb ljharb merged commit 4a32716 into tc39:main Mar 12, 2023
@mdjermanovic mdjermanovic mentioned this pull request Mar 13, 2023
Merged
1 task
jmdyck added a commit to jmdyck/ecma262 that referenced this pull request Mar 18, 2023
@jmdyck
Editorial: Re-word a TypedArray table lookup
693205d 
During review of PR tc39#2997, @michaelficarra suggested changing:
> the intrinsic object listed in column one of {Table 68} for _exemplar_.[[TypedArrayName]]
to:
> the intrinsic object associated with the constructor name _exemplar_.[[TypedArrayName]] in {Table 68}
in the new AO TypedArrayCreateSameType.
(tc39#2997 (review))

This commit makes the same change in the pre-existing AO TypedArraySpeciesCreate.
@Josh-Cena Josh-Cena mentioned this pull request Mar 20, 2023
Merged
@ljharb ljharb removed the editor call to be discussed in the next editor call label Mar 21, 2023
ljharb pushed a commit to jmdyck/ecma262 that referenced this pull request Mar 21, 2023
@jmdyck @ljharb
Editorial: Re-word a TypedArray table lookup (tc39#3031)
eb16aed 
During review of PR tc39#2997, @michaelficarra suggested changing:
> the intrinsic object listed in column one of {Table 68} for _exemplar_.[[TypedArrayName]]
to:
> the intrinsic object associated with the constructor name _exemplar_.[[TypedArrayName]] in {Table 68}
in the new AO TypedArrayCreateSameType.
(tc39#2997 (review))

This commit makes the same change in the pre-existing AO TypedArraySpeciesCreate.
@LightQuanta LightQuanta mentioned this pull request Jun 7, 2024
Closed
@LumaKernel LumaKernel mentioned this pull request Sep 9, 2024
Closed
@bakkot bakkot mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmdyck jmdyck jmdyck left review comments

@syg syg syg approved these changes

@ljharb ljharb ljharb left review comments

@bakkot bakkot bakkot approved these changes

@michaelficarra michaelficarra michaelficarra approved these changes

Assignees
No one assigned
Labels
has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@acutmore @jmdyck @ljharb @syg @michaelficarra @bakkot