Editorial: IfAbrupt macros only take completion records #2817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syg
approved these changes
Aug 17, 2022
michaelficarra
added
the
ready to merge
bakkot
removed
the
ready to merge
|
Waiting on #2842. |
bakkot
added
the
ready to merge
ljharb
force-pushed
the
if-abrupt-completions
branch
from
131e145 to
4bb59ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #2547 (edit: plus #2744 and #2842), it is always statically knowable whether a given expression at a given point is a Completion Record or not a Completion Record. So the various completion record unwrapping macros don't need to have a "what if it is not a completion record" case.