Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Complete structured headers in “Specification Types” #2589

Conversation

ExE-Boss
Copy link
Contributor

This fills in the remaining structured header type information in the “ECMAScript Specification Types” section.

spec.html Outdated Show resolved Hide resolved
@ExE-Boss ExE-Boss force-pushed the editorial/structured-headers/specification-types branch from 3986e1e to 200ee52 Compare November 29, 2021 07:38
@ExE-Boss ExE-Boss requested a review from jmdyck November 29, 2021 07:39
Copy link
Collaborator

@jmdyck jmdyck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces parameter 'types' involving Completion Record that might be affected by "completion value reform". So I'm not sure it's worth landing this PR before that's settled.

Co-authored-by: Michael Dyck <jmdyck@ibiblio.org>
@ExE-Boss ExE-Boss force-pushed the editorial/structured-headers/specification-types branch from 200ee52 to 10fba2d Compare February 28, 2022 17:46
@jmdyck
Copy link
Collaborator

jmdyck commented Sep 30, 2022

I believe this PR can be closed. Some of its changes were overtaken/obsoleted by Completion reform + PR #2842, and the rest were accomplished by PR #2745.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants