Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix next method #1021

Merged
merged 4 commits into from
Oct 16, 2017
Merged

Fix next method #1021

merged 4 commits into from
Oct 16, 2017

Conversation

bterlson
Copy link
Member

This is a continuation of #988.

@bterlson bterlson mentioned this pull request Oct 16, 2017
Closed
@bterlson
Copy link
Member Author

Looks good, thanks @kmiller68!!

@bterlson bterlson merged commit aa16347 into tc39:master Oct 16, 2017
@bterlson
Copy link
Member Author

bterlson commented Oct 16, 2017 •
edited by ljharb
Loading

I'm really sorry @kmiller68, it looked like github was going to take your metadata since it was showing up on the commits in this PR, but once I squashed it used mine. I'll try not to completely bungle the PR process going forward :)

@kmiller68
Copy link
Contributor

@bterlson No worries. Thanks for reviewing the patch! :)

@Jamesernator Jamesernator mentioned this pull request Nov 12, 2017
Open
domenic added a commit to tc39/proposal-async-iteration that referenced this pull request Dec 4, 2017
@domenic
Align with the base spec in caching "next" methods
36c46be 
Closes #116. See tc39/ecma262#1021.
@domenic domenic mentioned this pull request Dec 4, 2017
Merged
domenic added a commit to tc39/proposal-async-iteration that referenced this pull request Dec 6, 2017
@domenic
Align with the base spec in caching "next" methods
bf36f72 
Closes #116. See tc39/ecma262#1021.
@bterlson bterlson mentioned this pull request Jul 9, 2018
Closed
@mathiasbynens mathiasbynens mentioned this pull request Jan 9, 2019
Closed
@mathiasbynens mathiasbynens mentioned this pull request Apr 10, 2019
Closed
zloirock added a commit to zloirock/core-js that referenced this pull request Sep 1, 2019
@zloirock
access the .next method once, at the beginning, of the iteration pr…
2dff41a 
…otocol, missed cases

tc39/ecma262#976
tc39/ecma262#988
tc39/ecma262#1021
@bergus bergus mentioned this pull request Sep 10, 2022
Closed
@bakkot bakkot mentioned this pull request Oct 3, 2023
Closed
This was referenced Oct 3, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bterlson @kmiller68