Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting editorial conventions #2236

Open
bakkot opened this issue Nov 29, 2020 · 6 comments
Open

Documenting editorial conventions #2236

bakkot opened this issue Nov 29, 2020 · 6 comments

Comments

@bakkot
Copy link
Contributor

bakkot commented Nov 29, 2020

The editors should write down editorial conventions for the benefit of contributors and future editors, perhaps in tc39/how-we-work.

I've tried to automatically enforce some of them in ecmarkup. But there's plenty of others. Let's use this issue to collect them for now.

@michaelficarra
Copy link
Member

Might be a good use of GitHub's wiki feature? They can be configured so that only maintainers can make edits.

@bakkot
Copy link
Contributor Author

bakkot commented Dec 16, 2020

Here's a good one: under what circumstances do we pre-declare our aliases? See e.g. #1908 (comment), #2221 (comment).

@bakkot
Copy link
Contributor Author

bakkot commented Mar 2, 2022

As of #2547, we should also include the rules for completion records: use of ! / ? / Completion(...) for calls of completion-record-returning AOs, non-use of those things for non-completion-record-returning AOs.

@michaelficarra
Copy link
Member

We prefer spec enums over strings/constructors/instrinsics where they are just being switched over (aka used as an enum). See tc39/ecma402#689

ptomato added a commit to tc39/how-we-work that referenced this issue Aug 26, 2022
This can be a place to put items from
tc39/ecma262#2236 as they are discussed.

I've pre-populated it with h2 headings that roughly match the kinds of
conventions discussed in that issue.
ptomato added a commit to tc39/how-we-work that referenced this issue Feb 13, 2023
This can be a place to put items from
tc39/ecma262#2236 as they are discussed.

I've pre-populated it with h2 headings that roughly match the kinds of
conventions discussed in that issue.
@bakkot
Copy link
Contributor Author

bakkot commented Jun 11, 2023

We generally do validation first, then the happy path. So e.g. 1. If not in range, throw. 2. Return value., rather than 1. If in range, return value. 2. Throw.

@michaelficarra
Copy link
Member

I've started work on this here: https://github.com/tc39/ecma262/wiki/Editorial-Conventions

ptomato added a commit to tc39/how-we-work that referenced this issue Jun 27, 2024
This can be a place to put items from
tc39/ecma262#2236 as they are discussed.

I've pre-populated it with h2 headings that roughly match the kinds of
conventions discussed in that issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@michaelficarra @bakkot and others