-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding timestamps on S3 metadata #132
base: master
Are you sure you want to change the base?
Conversation
The data dir already points to the "data" directory.
If --no-sstableloader option is set then files will just be downloaded.
Add verbose output to know which file is processed.
--local allows to restore data directly on the local server where the command is run. The filenames are not prefixed by `<HOST>_` because we restore from only one node in this mode, so it would be useless. Rename --cassandra-data-dir to --restore-dir because: * it's just a temporary directory when restoring with sstableloader * it's safer to download data in a different location than the Cassandra data directory as a first step when doing a local restore with --local
Fixed conflicts with current README on master
…shotter into s3_metadata
…s the timestamp of the modification time of the file on the origin filesystem.
…s the timestamp of the modification time of the file on the origin filesystem.
Also tested a local restore and working fine:
Those
What else do you need @rhardouin @tbarbugli to get this merged? |
Included changes proposed on this PR #93 and also adding the following changes:
Keep mtime and atime during file restoration (they're stored as metadata on S3), that's useful for incremental backups if you need to restore specific sstables for a time period given.
Include S3 connection host for restoration workers. Needed for S3 buckets that requires signature version 4.