Add support to configure path to snapshotter agent #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to configure the path to the snapshotter agent.
We've installed snapshotter in a virtualenv and not at the global system level. As such, cassandra-snapshotter-agent is not globally accessible. And as a result, when we run a backup, the remote command fails because it's unable to find the path to cassandra-snapshotter-agent.
This PR allows us to configure the path to the cassandra-snapshotter-agent when we execute the remote command.
Here is an example of how we can use this new parameter.
cassandra-snapshotter --s3-bucket-name=foo_backup_bucket ... --snapshotter-agent-path '... pyenv activate snapshotter-venv cassandra-snapshotter-agent'