Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(bench): fix benchmark compilation error #1029

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Sep 30, 2023

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

CI is failing because benchmark is broken due to compilation errors. This PR fixes them.

I confirmed the benchmark job passed on my forked repository: https://github.com/rhysd/wry/actions/runs/6362544684/job/17277632961

@rhysd rhysd requested a review from a team as a code owner September 30, 2023 12:05
@wusyong
Copy link
Member

wusyong commented Oct 1, 2023

Thanks for the PR! Could you sign the commits? I'll merge it once it's signed.

Signed-off-by: rhysd <lin90162@yahoo.co.jp>
@rhysd
Copy link
Contributor Author

rhysd commented Oct 1, 2023

@wusyong I signed my commit and force-pushed at 5f2cecc.

@wusyong wusyong merged commit a179e37 into tauri-apps:dev Oct 2, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants