-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bundler): Add Pacman Packaging, closes #3728 , #4301 #8656
base: 1.x
Are you sure you want to change the base?
Conversation
Btw, the docs needs to be updated as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you're targeting 1.x branch, we should target dev
instead.
/// Returns a vector of PathBuf that shows where the archive.tar.gz was created. | ||
pub fn bundle_project(settings: &Settings) -> crate::Result<Vec<PathBuf>> { | ||
let arch = match settings.binary_arch() { | ||
// Arch Linux recognises `x86_64` and `aarch64` instead of `amd64` and `arm64` respectively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Arch Linux recognises `x86_64` and `aarch64` instead of `amd64` and `arm64` respectively. | |
// Arch Linux recognizes `i386` instead of `x86`. |
|
||
let (data_dir, _) = generate_data(settings, &package_dir) | ||
.with_context(|| "Failed to build data folders and files")?; | ||
copy_custom_files(settings, &data_dir).with_context(|| "Failed to copy custom files")?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this will use files
under deb
config, we should add a files
option for pacman
instead and change copy_custom_files
function to be more generic, we should do the same for appimage
as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agreed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
Great News for Arch Linux users!
Tauri is going to support Arch Linux packages by default 🎉
Although docs are yet to be added, you all are welcome to test the new changes.
If you face any issue / want to request additional features, feel free to add your comments.
Thank You