-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ability to reset allowed/forbidden fs scope paths, closes #7366 #7371
base: 1.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
uh I should've noticed this earlier, @LacombeJ could you rebase this PR to target |
Yeah sure, I was actually going to ask about that |
672cf41
to
de6c9f2
Compare
@amrbashir Let me know if I rebased properly. This reset signature takes two arguments because 1.x has two possible scopes unlike dev/2.0. pub fn reset<R: crate::Runtime>(&self, &App<R>, scope: &FsAllowlistScope) -> crate::Result<()>
scope.reset(&app, &app.config().tauri.allowlist.fs.scope).unwrap();
scope.reset(&app, &app.config().tauri.allowlist.protocol.asset_scope).unwrap(); |
Now I see it's kinda hard to use the ResetScope values so we could actually add a function that pulls a ResetScope and readds the patterns to the Scope. |
This now just needs an approval from the security team. |
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
Issue: #7366