Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macos): Expose tao event Event::Reopen, closes #3084 #4865

Merged
merged 5 commits into from
May 7, 2024

Conversation

BillGoldenWater
Copy link
Contributor

@BillGoldenWater BillGoldenWater commented Aug 4, 2022

…for handle click on dock icon on macOS.

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

in macOS the app usually doesn't exit when all window closed, and will use click on dock icon for reopen window.


depends on tauri-apps/tao#517, tauri-apps/tao#913

@BillGoldenWater BillGoldenWater marked this pull request as ready for review May 2, 2024 15:01
@BillGoldenWater BillGoldenWater requested a review from a team as a code owner May 2, 2024 15:01
@BillGoldenWater BillGoldenWater changed the title feat(macos): Expose tao event Event::ApplicationShouldHandleReopen feat(macos): Expose tao event Event::Reopen May 2, 2024
@pronebird

This comment has been minimized.

@BillGoldenWater BillGoldenWater changed the title feat(macos): Expose tao event Event::Reopen feat(macos): Expose tao event Event::Reopen, closes #3084 May 3, 2024
@pronebird
Copy link
Contributor

pronebird commented May 4, 2024

Linked PR: tauri-apps/tao#517

.changes/event-reopen.md Outdated Show resolved Hide resolved
@amrbashir
Copy link
Member

@BillGoldenWater a new tao version has been released, you can update it in your PR

@amrbashir amrbashir merged commit 78839b6 into tauri-apps:dev May 7, 2024
17 of 19 checks passed
@amrbashir
Copy link
Member

Thanks @BillGoldenWater

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔎 In audit
Development

Successfully merging this pull request may close these issues.

3 participants