Skip to content

Commit

Permalink
Revert "feat(core): add app-region: drag to data-tauri-drag-region (
Browse files Browse the repository at this point in the history
#9789)" (#9860)

* Revert "feat(core): add `app-region: drag` to `data-tauri-drag-region` (#9789)"

This reverts commit ae6b13d.

* Update pre.json

* change files

* Discard changes to .changes/pre.json
  • Loading branch information
amrbashir authored May 29, 2024
1 parent 5e8aa6f commit dfd0544
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
7 changes: 7 additions & 0 deletions .changes/revert-app-region-drag.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
"tauri": patch:bug
---

Revert adding `app-region: drag` to HTML elements with `data-tauri-drag-region` on Windows as it has a few issues:
- Doesn't allow right click, as it will always show the system context menu on right click.
- `data-tauri-drag-region` works only if the click was on an element that has it, this allows buttons in the custom titlebar to work, however `app-region: drag` will treat the whole area as a titlebar won't even allow clicks on buttons.
5 changes: 0 additions & 5 deletions core/tauri/src/window/scripts/drag.js
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,4 @@
}
})
}
if (osName === 'windows' && 'adoptedStyleSheets' in document) {
const sheet = new CSSStyleSheet()
sheet.replaceSync('*[data-tauri-drag-region] { app-region: drag; }')
document.adoptedStyleSheets = [...document.adoptedStyleSheets, sheet]
}
})()

0 comments on commit dfd0544

Please sign in to comment.