Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Force the same version bumps for rs and js packages #2130

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

FabianLars
Copy link
Member

I just fucked up the fs plugin and can't unpublish the js package because it has dependencies.

what i actually wanted to have was to remove the -js bumps and have the "rust" bumps work for both packages but i don't think that's possible with covector? idk covector is too hard for me so i went with this for now.

To be clear, the idea is to have matching versions for the rust and javascript packages of a plugin but not across plugins.

Once CI is happy i'll remove the test files and add a changefile for all plugins, to then bump all plugins to the same minor in the covector PR to mark the start of the synced version.

@FabianLars FabianLars requested a review from a team as a code owner December 3, 2024 13:50
@FabianLars
Copy link
Member Author

Okay, CI is stuck on other workflows. I'll mark this as a draft because i have to leave for a few hours.

@FabianLars FabianLars marked this pull request as draft December 3, 2024 13:53
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Package Changes Through 3cc64d0

No changes.

Add a change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@FabianLars
Copy link
Member Author

Copying my discord message:

This approach fixes a couple issues:

  1. makes it easy to identify versions that work together
  2. makes the version specifier in tauri add make sense
  3. makes it possible to have an automatic check in tauri dev or tauri info to confirm js == rs

@FabianLars FabianLars marked this pull request as ready for review December 3, 2024 18:35
@FabianLars FabianLars merged commit fe610d6 into v2 Dec 5, 2024
8 checks passed
@FabianLars FabianLars deleted the ci/synced-versions branch December 5, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant