Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(window-state)!: saving minimized state #1743

Merged
merged 8 commits into from
Sep 13, 2024

Conversation

Legend-Master
Copy link
Contributor

@Legend-Master Legend-Master commented Sep 6, 2024

#1702 didn't actually work, we save the state on move event, and it fires on minimize so...

Also updated the API example to include window state plugin

@Legend-Master Legend-Master requested a review from a team as a code owner September 6, 2024 15:17
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Package Changes Through 82c20fa

There are 1 changes which include window-state with prerelease

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
window-state 2.0.0-rc.3 2.0.0-rc.4

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

@Legend-Master
Copy link
Contributor Author

Legend-Master commented Sep 6, 2024

I wonder if we need to update the size on resize event, since we can't get it if we're existing from minimized state, also I'm seeing that we have prev_x and prev_y to track the pre-maximized state, we might as well just add prev_width and prev_height, also in that case, is it a good idea not to track the minimized state in move/resize event and just save the minimize state and use the previous value on restore instead?

@Legend-Master Legend-Master changed the title fix(window-state): saving minimized state again fix(window-state)!: saving minimized state Sep 7, 2024
@Legend-Master
Copy link
Contributor Author

Went with the basic approach, just checking the maximize and minimize state on resize event

@amrbashir amrbashir merged commit 204e5aa into tauri-apps:v2 Sep 13, 2024
16 checks passed
@Legend-Master Legend-Master deleted the window-state-minimized branch September 13, 2024 03:31
Sir-Thom pushed a commit to Sir-Thom/plugins-workspace that referenced this pull request Oct 22, 2024
* Fix saving minimized state again

* Add change file

* Fix saving minimized size

* Add change file

* Fix missing .md

* Remove window-shadows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants