Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(window-state): add Builder::map_label method #1497

Merged
merged 6 commits into from
Jun 26, 2024
Merged

feat(window-state): add Builder::map_label method #1497

merged 6 commits into from
Jun 26, 2024

Conversation

ferreira-tb
Copy link
Contributor

@ferreira-tb ferreira-tb commented Jun 25, 2024

This PR implements amrbashir's suggestion made when reviewing this other PR.

My use case is incredibly similar to that of the author of that other PR, as I'm also working on a comic reader app.

This is my first code PR to the project, so I probably did some mistakes.

This change is already being tested on my WIP app, as can be seen here.

@ferreira-tb ferreira-tb requested a review from a team as a code owner June 25, 2024 18:17
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, We also need to update save_window_state function logic to accommodate these changes

plugins/window-state/src/lib.rs Outdated Show resolved Hide resolved
plugins/window-state/src/lib.rs Outdated Show resolved Hide resolved
plugins/window-state/src/lib.rs Outdated Show resolved Hide resolved
.changes/window-state-map-label.md Outdated Show resolved Hide resolved
@ferreira-tb
Copy link
Contributor Author

Thanks for the review.

I really overlooked the save_window_state function, sorry about that. I updated it now, but I need opinions on whether my approach was appropriate.

About style: when using tuples, it is preferable to access by indexes, i.e. |(x)| x.1? Is something like |(y, _)| y appropriate?

plugins/window-state/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contribution

@amrbashir amrbashir changed the title feat(window-state): add map_label option feat(window-state): add Builder::map_label method Jun 26, 2024
@amrbashir amrbashir merged commit f1372ad into tauri-apps:v2 Jun 26, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants