-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(window-state): add Builder::map_label
method
#1497
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, We also need to update save_window_state
function logic to accommodate these changes
Thanks for the review. I really overlooked the About style: when using tuples, it is preferable to access by indexes, i.e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contribution
map_label
optionBuilder::map_label
method
This PR implements amrbashir's suggestion made when reviewing this other PR.
My use case is incredibly similar to that of the author of that other PR, as I'm also working on a comic reader app.
This is my first code PR to the project, so I probably did some mistakes.
This change is already being tested on my WIP app, as can be seen here.