Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix prettier peer dependency #24

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

sachinraja
Copy link
Contributor

@sachinraja sachinraja commented Jul 8, 2022

We need this so npm installs correctly. I think this also fixes it for yarn v3 and pnpm.

See https://docs.npmjs.com/cli/v7/configuring-npm/package-json#peerdependenciesmeta for docs on peerDependenciesMeta

@codecov
Copy link

codecov bot commented Jul 8, 2022

Codecov Report

Merging #24 (3765b6d) into main (7bf7868) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #24   +/-   ##
=======================================
  Coverage   98.24%   98.24%           
=======================================
  Files           1        1           
  Lines          57       57           
  Branches       13       13           
=======================================
  Hits           56       56           
  Misses          1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bf7868...3765b6d. Read the comment docs.

@tatethurston
Copy link
Owner

Thanks, I thought about removing prettier as a peer dependency, but I'm still on the fence. Any thoughts?

@tatethurston tatethurston merged commit 5f4ee87 into tatethurston:main Jul 8, 2022
@sachinraja sachinraja deleted the fix-peer-deps branch July 8, 2022 17:45
@sachinraja
Copy link
Contributor Author

sachinraja commented Jul 8, 2022

I don't think the file needs formatting to be honest. Users should have it ignored, and we can add a prettier-ignore to make sure it is. FYI I've got another fix coming, probably should have told you not to release this yet.

@tatethurston
Copy link
Owner

Cool, yeah I think so too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants