This repository has been archived by the owner on Oct 18, 2022. It is now read-only.
Fix bug with unresolved load promise when Facebook SDK already loaded #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes tatango#51 - Implement an assertion to warn developers when the SDK has already been loaded by some external source, e.g. another addon. - Implement a method of passing a promise which resolves with the FB object via the facebookSDK attribute. Allow developers to bring-their-own SDK per component and allow to override globally.
|
Thanks @sandydoo ! This looks ok to me. Haven't got the bandwidth to fix failing tests on travis though. Will need awhile to circle back. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51
Implement an assertion to warn developers when the SDK has already been
loaded by some external source, e.g. another addon.
Implement a method of passing a promise which resolves with the FB object via
the facebookSDK attribute. Allow developers to bring-their-own SDK per
component and allow to override globally.