Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve temporarily open_basedir issue #1061

Merged
merged 4 commits into from
Dec 27, 2023

Conversation

Concreta09
Copy link
Contributor

Resolve open_basedir issue adding dot for relativize filename path

Resolve open_basedir issue adding dot for relativize filename path
@sampoyigi
Copy link
Member

Can you add some description of what issue this is solving?

@Concreta09
Copy link
Contributor Author

Concreta09 commented Dec 9, 2023

Can you add some description of what issue this is solving?

When hosting has open_basedir configured and the file is checked by File::isFile() method if the file name start with a slash it's result out of the authorized paths, with relative path all works fine.

example

Schermata del 2023-12-09 16-39-26

See

https://discord.com/channels/486734519798333440/534045257730359309/1092545452957765723

Set open_basedir as "none" is a bad idea (and some shared hosting don't allow it) for security reason

https://discord.com/channels/486734519798333440/534045257730359309/1061302551418515506

@sampoyigi sampoyigi self-requested a review December 27, 2023 23:21
Signed-off-by: Sam Poyigi <6567634+sampoyigi@users.noreply.github.com>
@sampoyigi sampoyigi merged commit f916a34 into tastyigniter:3.x Dec 27, 2023
13 checks passed
@sampoyigi
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants