Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated with "Learn" infobar. #6

Merged
merged 1 commit into from
May 25, 2013

Conversation

stephenplusplus
Copy link
Member

(TodoMVC:#547)

The new files!

@stephenplusplus
Copy link
Member Author

Oh, also moved component.json -> bower.json and did a version bump to 0.1.7. Happy to pull those out if you prefer.

@@ -1,4 +1,4 @@
{
"name": "todomvc-common",
"version": "0.1.6"
"version": "0.1.7"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya, don't bump as it's easier to just do npm version which bumps number and tags

@stephenplusplus
Copy link
Member Author

@sindresorhus Just updated. Is that what you were thinking?

Here's the new template:

<header>
  <h3><%= name %></h3>
  <span class=\"source-links\">
    <% examples.forEach(function (example) { %>
    <h5><%= example.name %></h5>
    <% if (!location.href.match(example.url + '/')) { %>
    <a class=\"demo-link\" href=\"<%= example.url %>\">Demo</a>, 
    <% } %>
    <a href=\"https://github.com/tastejs/todomvc/tree/gh-pages/<%= example.source_url ? example.source_url : example.url %>\">Source</a>
    <% }); %>
  </span>
</header>
<hr>
<blockquote class=\"quote speech-bubble\">
  <p><%= description %></p>
  <footer>
    <a href=\"http://<%= homepage %>\"><%= name %></a>
  </footer>
</blockquote>
<hr>
<% link_groups.forEach(function (link_group) { %>
<h4><%= link_group.heading %></h4>
<ul>
  <% link_group.links.forEach(function (link) { %>
  <li>
    <a href=\"<%= link.url %>\"><%= link.name %></a>
  </li>
  <% }); %>
</ul>
<% }); %>
<footer>
  <hr>
  <em>If you have other helpful links to share, or find any of the links above no longer work, please <a href=\"https://github.com/tastejs/todomvc/issues\">let us know</a>.</em>
</footer>

If there's a better way to do the template or the code, let me know. When we finalize this, I'll send in a PR to TodoMVC with the new code / updated learn.json file.

@passy
Copy link
Member

passy commented May 19, 2013

I like it. Definitely easier to read. :)

@stephenplusplus
Copy link
Member Author

Agreed!

@sindresorhus
Copy link
Member

👍

@stephenplusplus
Copy link
Member Author

Updated to please tastejs/todomvc#568.

@stephenplusplus
Copy link
Member Author

screen shot 2013-05-25 at 9 10 44 am

May I? :)

@passy
Copy link
Member

passy commented May 25, 2013

Go for it! :)

stephenplusplus added a commit that referenced this pull request May 25, 2013
updated with "Learn" infobar.
@stephenplusplus stephenplusplus merged commit 3f7b692 into tastejs:master May 25, 2013
@stephenplusplus stephenplusplus deleted the infobar branch May 25, 2013 13:21
@stephenplusplus
Copy link
Member Author

I'm not sure how to do the version bump without manually editing bower.json. What's the ideal procedure to do a release?

@passy
Copy link
Member

passy commented May 25, 2013

That's actually what I did so far for bower components. Manually edit, tag and push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants