Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade dependencies #4

Merged
merged 1 commit into from
Aug 28, 2024
Merged

build: upgrade dependencies #4

merged 1 commit into from
Aug 28, 2024

Conversation

ThisIsManta
Copy link
Contributor

Problems

Dependabot reports the following security alerts

image

@ThisIsManta ThisIsManta merged commit f6bd692 into master Aug 28, 2024
@ThisIsManta ThisIsManta deleted the manta/up branch August 28, 2024 05:42
"lefthook": "^1.6.1",
"typescript": "^5.3.3",
"vitest": "^1.2.2"
"@thisismanta/semantic-version": "^9.1.0",
Copy link

@y-nk y-nk Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would recommend configuring https://github.com/amannn/action-semantic-pull-request so that maintenance is out of our hands. reading code of the action, features are covered to 100% (if i'm not mistaken)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm using this for my other open source projects so I don't mind maintaining.

This library does more than just validating commit messages though. It provides another command to run npm version and git push on CI. This is to avoid boilerplates.

I don't mind replacing it for Taskworld, if you have a strong opinion.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually i side with using the mode known approach so that i dont need to rebuild the wheel or maintain it, and that any other engineer can. that one is standardly used across codebases which checks for semantic title (which is not all of them), although configuration is not aligned so it's not 100% on par (so far).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants