fix(job-scheduler): avoid duplicates when upserting in a quick sequence #2991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manast
requested review from
roggervalf and
fgozdz
and removed request for
roggervalf
roggervalf
approved these changes
Dec 31, 2024
tests/test_job_scheduler.ts
Outdated
| beforeEach(async function () { | ||
| const date = new Date('2017-02-07 9:24:00'); | ||
| this.clock.setSystemTime(date); | ||
| worker = new Worker( |
There was a problem hiding this comment.
beforeEach and afterEach in this describe block is only affecting one test, they can be placed inside that test
roggervalf
force-pushed
the
fix/multiple-delayed-jobs-upserting-succession
branch
from
2c967b7 to
975656a
Compare
roggervalf
deleted the
fix/multiple-delayed-jobs-upserting-succession
branch
github-actions bot
pushed a commit
that referenced
this pull request
Dec 31, 2024
## [5.34.6](v5.34.5...v5.34.6) (2024-12-31) ### Bug Fixes * **job-scheduler:** avoid duplicates when upserting in a quick sequence ([#2991](#2991)) ([e8cdb99](e8cdb99))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR fixes this issue: #2988
How
This PR makes sure that the "nextMillis" portion of every repeatable jobs is always calculated on well defined so called "time slots". The offset is only used to calculate the "delay" option of the repeatable job so that it repeats at the appropriate time, but is not used for the "nextMillis" calculation anymore.