feat: add SafePassword struct #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
therustmonk
force-pushed
the
dk-password-type
branch
from
48ffeed to
c9f3f35
Compare
src/password.rs
Outdated
| #[derive(Clone, Debug, Serialize, Deserialize, PartialEq, Eq)] | ||
| #[serde(transparent)] | ||
| pub struct SafePassword { | ||
| password: Hidden<String>, |
There was a problem hiding this comment.
Should this not be a slice so that reallocations can't happen?
There was a problem hiding this comment.
Good point 👍 Done
therustmonk
force-pushed
the
dk-password-type
branch
from
c9f3f35 to
923d80e
Compare
therustmonk
force-pushed
the
dk-password-type
branch
from
923d80e to
d7e0d53
Compare
stringhandler
previously approved these changes
Jul 21, 2022
stringhandler
approved these changes
Jul 26, 2022
stringhandler
pushed a commit
to tari-project/tari
that referenced
this pull request
Aug 3, 2022
Description --- This update replaces `String` types with `SafePassword` wrapper to be sure app the passwords: - zeroized - never printed Related: tari-project/tari_utilities#46 Motivation and Context --- To guarantee all the passphrases erased. How Has This Been Tested? --- CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR introduces a special wrapper for passphrases that guarantees the data will be erased when value dropped.
Notes:
unicode-identdependency adds extraUnicode-DFS-2016license since1.0.2: https://crates.io/crates/unicode-ident/versionsdeny.toml), becauseUnicode-DFS-2016is approved by OSI: https://opensource.org/node/1077