feat: keep keys in compressed form #6753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results (Integration tests) 2 files 11 suites 31m 9s ⏱️ For more details on these failures, see this check. Results for commit 028135a. ♻️ This comment has been updated with latest results. |
Test Results (CI) 3 files 129 suites 38m 3s ⏱️ Results for commit 028135a. ♻️ This comment has been updated with latest results. |
SWvheerden
changed the title
SWvheerden
force-pushed
the
sw_compressed_keys
branch
2 times, most recently
from
e319861 to
6858def
Compare
wip building fix more tests WIP on sw_compressed_keys more fixes remove useless test wip small changes refactor names remove public view key display up version
SWvheerden
force-pushed
the
sw_compressed_keys
branch
from
2493a32 to
75b8e47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Keeps all crypto public keys in compressed form, and only uncompressing when needed.
Motivation and Context
This should improve speed and reduce the compression of keys. Comparing unit test speeds this PR is roughly the same as before. But unit test almost always do crypto operations to ensure everything is correct. Where this PR increases performance is when only reading something and providing it. For example, just reading the mainnet gen block in its current form on avg it takes 56 seconds. With this pr this time is taken down to on avg 15 seconds. Thats a 370% speed improvement.
How Has This Been Tested?
unit tests