chore: replace proxy mining with sha mining in tests #3455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SWvheerden
force-pushed
the
sw_replace_proxy
branch
from
9e7700a to
6d0b26e
Compare
SWvheerden
force-pushed
the
sw_replace_proxy
branch
2 times, most recently
from
4b1dca9 to
c796644
Compare
bump up block amounts rerorg speed improvement
SWvheerden
force-pushed
the
sw_replace_proxy
branch
from
c796644 to
06036d1
Compare
| @@ -96,7 +96,7 @@ Feature: Mempool | |||
| Then SENDER has TX1 in NOT_STORED state | |||
| Then SENDER has TX2 in MINED state | |||
|
|
|||
| @critical | |||
| @critical @flaky | |||
There was a problem hiding this comment.
How is this regressing now?
There was a problem hiding this comment.
Its a new test, created in PR #3439
It failed on CI this morning and I have not been able to get it to fail locally.
philipr-za
reviewed
Oct 15, 2021
stringhandler
approved these changes
Oct 15, 2021
| @@ -197,6 +199,8 @@ Feature: Reorgs | |||
| And I connect node NODE_B1 to node NODE_B3 and wait 1 seconds | |||
| And I connect node NODE_B2 to node NODE_B4 and wait 1 seconds | |||
| And I connect node SEED_B1 to node SEED_B2 and wait <SYNC_TIME> seconds | |||
There was a problem hiding this comment.
Perhaps we can remove this wait <SYNC_TIME> seconds and then keep the below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced merge mining proxy mining in most tests with sha3 miner.
Added base_node state to grpc for use in the tests
Motivation and Context
The monero merge mining proxy makes a network call to the outside which can be unreliable. The sha3 miner only uses local information which is faster as well.
We use sleeps that in the cucumber code to ensure that base_nodes have time to sync, we can just if they are in listening state to check if we can go to the next step
How Has This Been Tested?
Manual cucumber tests