feat: update coinbase handling for new tx and output validation #3383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new tx validation protocol would continuously try and revalidate abandoned coinbase transactions and the TXO validation would try validate abandoned or reforged Coinbases indefinitely. This PR updates the Tx validation handing of Coinbases to give them the Coinbase status when they are abandoned which means they won’t be revalidated but will still be checked during a reorg. The TXO validation has been updated so that ab abandoned coinbase can be marked as Abandoned when the transaction validation detects the abandonment so that the output will not be validated indefinitely. A new test is provided and a number of cucumber tests for this branch have been fixed.
philipr-za
force-pushed
the
philip-coinbase-validation
branch
from
33c2160 to
d7c690c
Compare
stringhandler
approved these changes
Sep 27, 2021
stringhandler
added a commit
that referenced
this pull request
Oct 6, 2021
alternate approach to transaction validation (#3191) feat!: integration of new transaction and output validation (#3352) feat: update coinbase handling for new tx and output validation (#3383) refactor: use wallet connectivity in wallet services (#3391) refactor: mapping for deleted mmr position to height/hash for perf (#3394) feat: Fix reinstating CancelledInbound outputs and fix tests (#3400) chore: merge development into tx-validation2 and fix issues (#3417) Uncomment cucumber tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new tx validation protocol would continuously try and revalidate abandoned coinbase transactions and the TXO validation would try validate abandoned or reforged Coinbases indefinitely.
This PR updates the Tx validation handing of Coinbases to give them the Coinbase status when they are abandoned which means they won’t be revalidated but will still be checked during a reorg. The TXO validation has been updated so that ab abandoned coinbase can be marked as Abandoned when the transaction validation detects the abandonment so that the output will not be validated indefinitely.
A new test is provided and a number of cucumber tests for this branch have been fixed.
How Has This Been Tested?
Unit test provided and cucumber tests updated