chore: mark broken tests and add interval print for long grpc call #3303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cifko
changed the title
stringhandler
approved these changes
Sep 6, 2021
Cifko
added a commit
to Cifko/tari
that referenced
this pull request
Sep 10, 2021
…ari-project#3303) Description --- Mark broken tests as @broken. Add a console print (once every 10 minutes). This will prevent the CI to kill the test. I've added Before step that print the name of the scenario. Because now when it fails in the middle and there is no cucumber output generated. It's hard to know which test it was. Because there is only console.log available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mark broken tests as @broken.
Add a console print (once every 10 minutes). This will prevent the CI to kill the test.
I've added Before step that print the name of the scenario. Because now when it fails in the middle and there is no cucumber output generated. It's hard to know which test it was. Because there is only console.log available.