Update mempool unit test to reflect actual behaviour. #3062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
stringhandler
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The test
block_event_and_reorg_event_handlingwas updated and fixed on thedevelpmentbranch.Given the following double spend:
On the
developmentbranch the following happened in the mempool with double spend:When Tx1 is mined:
Tx1 will go to the ReOrg pool.
Tx2 will be deleted.
On the
tari_scriptbranch the following happened in the mempool with double spend:When Tx1 is mined:
Tx1 will go to the ReOrg pool.
Tx2 will go to the ReOrg pool.
Motivation and Context
We need the test to reflect the actual behavior of the code, so this test is updated to reflect the actual behavior.
How Has This Been Tested?
Checklist:
developmentbranch.