Fix block_event_and_reorg_event_handling test. #3018
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there a better way to add empty block? |
delta1
reviewed
Jun 18, 2021
base_layer/core/tests/mempool.rs
Outdated
| @@ -754,7 +754,7 @@ fn service_request_timeout() { | |||
| #[ignore = "Flaky test that needs to be fixed"] | |||
There was a problem hiding this comment.
If the test is passing reliably now then you can remove this #[ignore] attribute so it can run on CI 👍
delta1
previously approved these changes
Jun 18, 2021
base_layer/core/tests/mempool.rs
Outdated
| #[allow(clippy::identity_op)] | ||
| fn block_event_and_reorg_event_handling() { | ||
| // #flaky, this test seems to fail after submiting block B2A to bob. | ||
| // #flaky, this test seems to fail after submitting block B2A to bob. |
There was a problem hiding this comment.
Sorry I forgot to ask to remove this comment as well!
There was a problem hiding this comment.
My bad, my spellchecker just noticed that mistake, next time I will read the comments more carefully.
delta1
approved these changes
Jun 18, 2021
stringhandler
added a commit
that referenced
this pull request
Jun 24, 2021
This PR fix 3 issues that were failing: The coinbase_lock_height is 2, so we had to add one empty block to be able to process the UTXO. The TXs were discarded because their input was invalid. Solution was to move it after the processing of the block1. Removal of assert_eq, there is proper one async_assert_eventually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix 3 issues that were failing: