Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trace log double-spend or invalid inputs #1836

Merged
merged 2 commits into from
May 11, 2020
Merged

Trace log double-spend or invalid inputs #1836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9917df1
We need more insight into nodes that are spamming the network with in…
hansieodendaal May 10, 2020
eebda63
Merge branch 'development' into ho_trace_log_invalid_transactions
hansieodendaal May 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion applications/tari_base_node/windows/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ installed automatically if selected:
Notes:
- Minimum Windows 7 64bit with Windows Powershell 3.0 required,
Windows 10 64bit recommended.
- Minimum 60GB free disk space required at the initial runtime.
- Minimum 1.2 GB free disk space required at the initial runtime.

## Runtime

Expand Down
15 changes: 14 additions & 1 deletion base_layer/core/src/mempool/service/inbound_handlers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,20 @@ where T: BlockchainBackend + 'static
);
let propagate = match tx_storage {
TxStorageResponse::UnconfirmedPool => true,
TxStorageResponse::OrphanPool => false,
TxStorageResponse::OrphanPool => {
trace!(
target: LOG_TARGET,
"Transaction `{}` received from nodeID `{}` is bad: double spend or non-existent \
input.",
tx.body.kernels()[0].excess_sig.get_signature().to_hex(),
exclude_peers
.first()
.as_ref()
.map(|p| format!("{}", p))
.unwrap_or_else(|| "local services".to_string())
);
false
},
TxStorageResponse::PendingPool => true,
TxStorageResponse::ReorgPool => false,
TxStorageResponse::NotStored => false,
Expand Down